Revision: 14569
Author: [email protected]
Date: Tue May 7 05:20:33 2013
Log: Object.observe: disable freezing changeRecords until it can be
made fast
R=rossberg,adamk
BUG=
Review URL: https://codereview.chromium.org/15017003
Patch from Rafael Weinstein <[email protected]>.
http://code.google.com/p/v8/source/detail?r=14569
Modified:
/branches/bleeding_edge/src/object-observe.js
=======================================
--- /branches/bleeding_edge/src/object-observe.js Fri Mar 22 10:27:44 2013
+++ /branches/bleeding_edge/src/object-observe.js Tue May 7 05:20:33 2013
@@ -138,7 +138,9 @@
var changeRecord = (arguments.length < 4) ?
{ type: type, object: object, name: name } :
{ type: type, object: object, name: name, oldValue: oldValue };
- ObjectFreeze(changeRecord);
+ // TODO(rafaelw): This breaks spec-compliance. Re-enable when freezing
isn't
+ // slow.
+ // ObjectFreeze(changeRecord);
EnqueueChangeRecord(changeRecord, objectInfo.changeObservers);
}
@@ -164,7 +166,9 @@
%DefineOrRedefineDataProperty(newRecord, prop, changeRecord[prop],
READ_ONLY + DONT_DELETE);
}
- ObjectFreeze(newRecord);
+ // TODO(rafaelw): This breaks spec-compliance. Re-enable when freezing
isn't
+ // slow.
+ // ObjectFreeze(newRecord);
EnqueueChangeRecord(newRecord, objectInfo.changeObservers);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
