https://codereview.chromium.org/14779011/diff/1/src/object-observe.js
File src/object-observe.js (right):
https://codereview.chromium.org/14779011/diff/1/src/object-observe.js#newcode70
src/object-observe.js:70: performing: { __proto__: null },
Google3 JS style is {key: value} (no whitespace inside {}) but stick to
the v8 style.
https://codereview.chromium.org/14779011/diff/1/src/object-observe.js#newcode128
src/object-observe.js:128: from.splice(count, 1);
splice is O(n). Usually it is better to put some kind of sentinel in the
array and then filter out the sentinels after the loop. That makes it
O(n) instead of O(n^2).
https://codereview.chromium.org/14779011/diff/1/test/mjsunit/harmony/object-observe.js
File test/mjsunit/harmony/object-observe.js (right):
https://codereview.chromium.org/14779011/diff/1/test/mjsunit/harmony/object-observe.js#newcode473
test/mjsunit/harmony/object-observe.js:473:
observer2.assertCallbackRecords([
Awesome test. Makes it really clear what the intent is.
https://codereview.chromium.org/14779011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
