Reviewers: Sven Panne,
Message:
Ptal. The calls to this function should now be removed from chromium &
blink, so
adding the V8_DEPRECATED shouldn't cause problems.
Description:
Deprecate the version of Context::New which returns a Persistent.
BUG=
Please review this at https://codereview.chromium.org/15059016/
SVN Base: git://github.com/v8/v8.git@master
Affected files:
M include/v8.h
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
3a86e86e020cbc9448c50f2ccd21476035a66c2e..a5562fe527a7a65546298ce3bbe1a5482033cf81
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -4609,11 +4609,10 @@ class V8EXPORT Context {
Handle<Value> global_object = Handle<Value>());
/** Deprecated. Use Isolate version instead. */
- // TODO(mstarzinger): Put this behind the V8_DEPRECATED guard.
- static Persistent<Context> New(
+ V8_DEPRECATED(static Persistent<Context> New(
ExtensionConfiguration* extensions = NULL,
Handle<ObjectTemplate> global_template = Handle<ObjectTemplate>(),
- Handle<Value> global_object = Handle<Value>());
+ Handle<Value> global_object = Handle<Value>()));
/** Returns the last entered context. */
static Local<Context> GetEntered();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.