lgtm
https://codereview.chromium.org/15023010/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/15023010/diff/1/include/v8.h#newcode698
include/v8.h:698: V8_INLINE(T* LeakPersistent());
Please add a comment that it is necessary to re-wrap the pointer later
and Dispose it, otherwise one keeps a Node live indefinitely.
https://codereview.chromium.org/15023010/diff/1/include/v8.h#newcode5408
include/v8.h:5408: T* Persistent<T>::LeakPersistent() {
As discussed offline, we should better name it "ClearAndLeak".
https://codereview.chromium.org/15023010/diff/1/include/v8.h#newcode5411
include/v8.h:5411: old = this->operator*();
Can we use '*this' here? If not, a comment might be good...
https://codereview.chromium.org/15023010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
