Reviewers: rossberg,
Description:
Fix bogus arguments length check in StringLocaleCompare.
[email protected]
TEST=test262/15.5.4.9_3
Please review this at https://codereview.chromium.org/14972015/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/string.js
M test/test262/test262.status
Index: src/string.js
diff --git a/src/string.js b/src/string.js
index
4cae85b02220bb171becf9ea78d72458b1a40297..44315bba168b20197194556986be5d2aa97f7a8a
100644
--- a/src/string.js
+++ b/src/string.js
@@ -170,7 +170,6 @@ function StringLocaleCompare(other) {
throw MakeTypeError("called_on_null_or_undefined",
["String.prototype.localeCompare"]);
}
- if (%_ArgumentsLength() === 0) return 0;
return %StringLocaleCompare(TO_STRING_INLINE(this),
TO_STRING_INLINE(other));
}
Index: test/test262/test262.status
diff --git a/test/test262/test262.status b/test/test262/test262.status
index
4d0dafad19bb5b2d50c3ce78036983d50b8b6743..4910939f15a8e7c5309d59b2d7b0746dfb94ce57
100644
--- a/test/test262/test262.status
+++ b/test/test262/test262.status
@@ -41,10 +41,6 @@ def FAIL_OK = FAIL, OKAY
# V8 Bug: http://code.google.com/p/v8/issues/detail?id=2413
15.5.4.9_CE: FAIL
-# Missing 'that' parameter should be treated as an implicit 'undefined'
when
-# String.prototype.localeCompare is called.
-15.5.4.9_3: FAIL
-
##################### DELIBERATE INCOMPATIBILITIES #####################
# This tests precision of Math functions. The implementation for those
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
