Reviewers: danno,
Message:
PTAL.
Description:
Fix missing hole check for loads from Smi arrays when all uses are changes
BUG=chromium:233737
Please review this at https://codereview.chromium.org/14978004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-instructions.h
A + test/mjsunit/regress/regress-crbug-233737.js
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index
ee83d5f49c6a5b2ea700c52eb1390c22e09ee76f..2e360c5d18521f56717c5bc18db858ee13609605
100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -5417,7 +5417,7 @@ class HLoadKeyed
IsFastDoubleElementsKind(elements_kind));
if (IsFastSmiOrObjectElementsKind(elements_kind)) {
- if (IsFastSmiElementsKind(elements_kind)) {
+ if (elements_kind == FAST_SMI_ELEMENTS) {
set_type(HType::Smi());
}
Index: test/mjsunit/regress/regress-crbug-233737.js
diff --git a/test/mjsunit/regress/regress-2671.js
b/test/mjsunit/regress/regress-crbug-233737.js
similarity index 86%
copy from test/mjsunit/regress/regress-2671.js
copy to test/mjsunit/regress/regress-crbug-233737.js
index
8da1b8f07f69c487fe9913e485c60f3e257e0986..835726b22429ec3cca68df956255d47c53fcfd25
100644
--- a/test/mjsunit/regress/regress-2671.js
+++ b/test/mjsunit/regress/regress-crbug-233737.js
@@ -27,19 +27,16 @@
// Flags: --allow-natives-syntax
-var y;
-function f() {
- var a = [];
- a[20] = 0;
- y = 3;
- var i = 7 * (y + -0);
- a[i] = 1/y;
- assertFalse(isNaN(a[i]));
-}
+var a = new Array(2);
+a[0] = 1;
+assertTrue(%HasFastSmiElements(a));
+assertTrue(%HasFastHoleyElements(a));
-f();
-f();
-f();
-%OptimizeFunctionOnNextCall(f);
-f();
+function hole(i) {
+ return a[i] << 0;
+}
+assertEquals(1, hole(0));
+assertEquals(1, hole(0));
+%OptimizeFunctionOnNextCall(hole);
+assertEquals(0, hole(1));
\ No newline at end of file
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
