Thanks for review, added more expanded comments, landing
On 2013/05/13 13:58:42, Michael Starzinger wrote:
LGTM with two nits.
https://codereview.chromium.org/15059009/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/15059009/diff/1/test/cctest/test-api.cc#newcode12060
test/cctest/test-api.cc:12060: // FunctionEntryHook does not work well
with
experimental natives.
Can we make this comments more specific as to what goes wrong? I was
thinking
along the lines of ...
// Experimental natives are compiled during snapshot deserialization.
// This test breaks because InstallGetter is compiled with entry hooks.
https://codereview.chromium.org/15059009/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/15059009/diff/1/test/cctest/test-heap.cc#newcode2811
test/cctest/test-heap.cc:2811: LocalContext env;
Can we just disable typed arrays and array buffers in this test case as
in the
other test cases? Also as with the other test case a short explanation of
what
breaks might help. I was thinking along the lines of ...
// Experimental natives are compiled during snapshot deserialization.
// This test breaks because heap layout changes in a way that closure
// is visited before shared function info.
https://codereview.chromium.org/15059009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
