A couple of nits and two real comments in the objects.cc file.
https://codereview.chromium.org/14604007/diff/11001/src/arm/deoptimizer-arm.cc
File src/arm/deoptimizer-arm.cc (right):
https://codereview.chromium.org/14604007/diff/11001/src/arm/deoptimizer-arm.cc#newcode61
src/arm/deoptimizer-arm.cc:61: // any more. Play safe and reset the
whole cache.
The second sentence of the comment is out-dated, let's just drop it.
https://codereview.chromium.org/14604007/diff/11001/src/ia32/deoptimizer-ia32.cc
File src/ia32/deoptimizer-ia32.cc (right):
https://codereview.chromium.org/14604007/diff/11001/src/ia32/deoptimizer-ia32.cc#newcode131
src/ia32/deoptimizer-ia32.cc:131: // any more. Play safe and reset the
whole cache.
The second sentence of the comment is out-dated, let's just drop it.
https://codereview.chromium.org/14604007/diff/11001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/14604007/diff/11001/src/objects.cc#newcode9066
src/objects.cc:9066: code_map->set(i, code_map->get(i + 1 +
kEntryLength));
The indices look suspiciously off in this loop!
https://codereview.chromium.org/14604007/diff/11001/src/objects.cc#newcode9080
src/objects.cc:9080: heap->CreateFillerObjectAt(filler_start,
This will destroy live-bytes count if incremental marking is active.
Please use the RightTrimFixedArray helper instead to do the trimming.
https://codereview.chromium.org/14604007/diff/11001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/14604007/diff/11001/src/objects.h#newcode5826
src/objects.h:5826: // all code objects if |optimized_code| is null.
The second part of the comment is out-dated, let's just drop it.
https://codereview.chromium.org/14604007/diff/11001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/14604007/diff/11001/src/runtime.cc#newcode8014
src/runtime.cc:8014: // Flush optimized code cache for this function.
The comment is outdated.
https://codereview.chromium.org/14604007/diff/11001/src/x64/deoptimizer-x64.cc
File src/x64/deoptimizer-x64.cc (right):
https://codereview.chromium.org/14604007/diff/11001/src/x64/deoptimizer-x64.cc#newcode62
src/x64/deoptimizer-x64.cc:62: // any more. Play safe and reset the
whole cache.
The second sentence of the comment is out-dated, let's just drop it.
https://codereview.chromium.org/14604007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
