Only minor comments. Go ahead with the platform ports.
https://codereview.chromium.org/14738009/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/14738009/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode984
src/ia32/lithium-codegen-ia32.cc:984: void
LCodeGen::SoftDeoptimizeIf(Condition cc,
Soft deopts are always unconditional, so you could remove the Condition
parameter and just hard-code "no_condition" in the call to DeoptimizeIf
(in line 987).
https://codereview.chromium.org/14738009/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/14738009/diff/1/src/runtime.cc#newcode8006
src/runtime.cc:8006: // Soft opts shouldn't count against the overall
re-optimization count that
nit: s/opts/deopts/
https://codereview.chromium.org/14738009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
