Reviewers: Jakob,
Message:
Platform ports done, tests run. Please take another look.
https://codereview.chromium.org/14738009/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/14738009/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode984
src/ia32/lithium-codegen-ia32.cc:984: void
LCodeGen::SoftDeoptimizeIf(Condition cc,
On 2013/05/14 11:01:57, Jakob wrote:
Soft deopts are always unconditional, so you could remove the
Condition
parameter and just hard-code "no_condition" in the call to
DeoptimizeIf (in line
987).
Done.
https://codereview.chromium.org/14738009/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/14738009/diff/1/src/runtime.cc#newcode8006
src/runtime.cc:8006: // Soft opts shouldn't count against the overall
re-optimization count that
On 2013/05/14 11:01:57, Jakob wrote:
nit: s/opts/deopts/
Done.
Description:
Ensure that soft-deopts don't count against opt_count
[email protected]
Please review this at https://codereview.chromium.org/14738009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
src/arm/builtins-arm.cc
src/arm/deoptimizer-arm.cc
M src/arm/lithium-codegen-arm.h
M src/arm/lithium-codegen-arm.cc
M src/builtins.h
M src/deoptimizer.h
M src/deoptimizer.cc
M src/disassembler.cc
M src/ia32/builtins-ia32.cc
M src/ia32/deoptimizer-ia32.cc
M src/ia32/lithium-codegen-ia32.h
M src/ia32/lithium-codegen-ia32.cc
M src/objects.cc
M src/runtime.cc
src/x64/builtins-x64.cc
src/x64/deoptimizer-x64.cc
src/x64/lithium-codegen-x64.h
src/x64/lithium-codegen-x64.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
