https://codereview.chromium.org/14862009/diff/8001/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/14862009/diff/8001/src/code-stubs.cc#newcode462
src/code-stubs.cc:462: stream->Remove(1);
On 2013/05/14 09:18:42, Sven Panne wrote:
Although it looks like a cunning idea at first, removing things from a
stream is
a bad idea conceptually. I want to refactor things to clearly
distinguish
between the conversion of an object to a sequence of characters and
the
character sink itself. This kind of hack would be counter-productive.
Just keep
track of the fact if you need to emit a separator by hand.
ok, ic
C++ sucks:
http://hackage.haskell.org/packages/archive/base/latest/doc/html/Data-List.html#v:intersperse
:-/
i know:
http://ruby-doc.org/core-2.0/Array.html#method-i-join
;)
https://codereview.chromium.org/14862009/diff/8001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/14862009/diff/8001/src/code-stubs.h#newcode1844
src/code-stubs.h:1844: byte ToByte() const { return ToIntegral(); }
On 2013/05/14 09:18:42, Sven Panne wrote:
Just using ToIntegral() is easier here, too. (I know this has been
there before
your change... :-)
This is still called from platform dependant code, which i anyway want
to completely remove in a later cl. so i'm not gonna remove that in this
cl
https://codereview.chromium.org/14862009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
