Please update per inline comments.
https://codereview.chromium.org/15005008/diff/1/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):
https://codereview.chromium.org/15005008/diff/1/src/mips/builtins-mips.cc#newcode1379
src/mips/builtins-mips.cc:1379:
nit: in c files, we need 2 blank lines between functions. Add one line
before and one line after this function.
https://codereview.chromium.org/15005008/diff/1/src/mips/builtins-mips.cc#newcode1381
src/mips/builtins-mips.cc:1381: Generate_NotifyDeoptimizedHelper(masm,
Deoptimizer::LAZY);
2nd parameter here should be Deoptimizer::SOFT (not LAZY)
https://codereview.chromium.org/15005008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
