Landing

https://codereview.chromium.org/15096011/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/15096011/diff/1/test/cctest/test-api.cc#newcode15887
test/cctest/test-api.cc:15887: static const int stack_breathing_room =
256 * 1024;
On 2013/05/15 08:23:48, Michael Starzinger wrote:
nit: Let's use the "KB" constant from globals.h instead of 1024 here.

Done.

https://codereview.chromium.org/15096011/diff/1/test/cctest/test-mark-compact.cc
File test/cctest/test-mark-compact.cc (right):

https://codereview.chromium.org/15096011/diff/1/test/cctest/test-mark-compact.cc#newcode474
test/cctest/test-mark-compact.cc:474: !(defined(__has_feature) &&
__has_feature(address_sanitizer))
I had to do this check slightly different, otherwise GCC doesn't like
it. :-(

https://codereview.chromium.org/15096011/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to