LGTM if you address my comment below.
https://codereview.chromium.org/14997008/diff/7001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/14997008/diff/7001/src/hydrogen-instructions.h#newcode1467
src/hydrogen-instructions.h:1467: class HBreak: public
HTemplateInstruction<0> {
I'd prefer to call this instruction HDebugBreak (and the lithium
equivalent LDebugBreak) to avoid confusion, since it doesn't have
anything to do with the JS "break" statement, whereas we already have an
OS::DebugBreak() that serves the same purpose in C++ code.
Also, a short comment here would be nice:
// Inserts an int3/stop break instruction for debugging purposes.
https://codereview.chromium.org/14997008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
