PTAL. On Tue, May 14, 2013 at 11:20 AM, <[email protected]> wrote: > > https://codereview.chromium.org/14779011/diff/18001/test/mjsunit/harmony/object-observe.js > File test/mjsunit/harmony/object-observe.js (right): > > https://codereview.chromium.org/14779011/diff/18001/test/mjsunit/harmony/object-observe.js#newcode380 > test/mjsunit/harmony/object-observe.js:380: function Thingy (a, b, c) { > On 2013/05/14 14:19:59, rossberg wrote: >> >> Nit: spurious space > > > Done. > > > https://codereview.chromium.org/14779011/diff/18001/test/mjsunit/harmony/object-observe.js#newcode484 > test/mjsunit/harmony/object-observe.js:484: ]); > On 2013/05/14 14:19:59, rossberg wrote: >> >> Can we also add a test that nests performChanges of the _same_ type, > > just to >> >> make sure that does not confuse the logic either? > > >> It might also be good to have a test that tries a broader range of > > modifications >> >> to 'this' inside a performChange, in particular, Array stuff. > > > Done. > > https://codereview.chromium.org/14779011/
-- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
