LGTM with a few more nits.
Let's discuss the higher-level situation on Friday.
https://codereview.chromium.org/14046017/diff/23001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/14046017/diff/23001/src/hydrogen-instructions.cc#newcode1204
src/hydrogen-instructions.cc:1204:
!induction_limit->block()->Dominates(my_pre_header)) continue;
another nit: {} please when the condition doesn't fit onto a single
line. Again below.
https://codereview.chromium.org/14046017/diff/23001/src/hydrogen-instructions.cc#newcode2106
src/hydrogen-instructions.cc:2106: HValue* induction_base_cantidate =
OperandAt(other_operand_index);
nit: s/cantidate/candidate/
https://codereview.chromium.org/14046017/diff/23001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/14046017/diff/23001/src/hydrogen-instructions.h#newcode871
src/hydrogen-instructions.h:871: bool result) :
nit: colon goes on the next line, with 4 spaces of indentation relative
to "NumericRelationTableElement(".
https://codereview.chromium.org/14046017/diff/23001/src/hydrogen-instructions.h#newcode880
src/hydrogen-instructions.h:880: NumericRelationTableElement(const
NumericRelationTableElement& other) :
nit: same here
https://codereview.chromium.org/14046017/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
