LGTM! just a few nits...
https://codereview.chromium.org/14794007/diff/10001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/14794007/diff/10001/src/mark-compact.cc#newcode1072
src/mark-compact.cc:1072: Code* code = Code::cast(code_map->get(i + 1));
Can we use a constant like kCodeOffset = 1 here? The same comment would
apply for the the code_map->get calls below. I think it improves
readability.
https://codereview.chromium.org/14794007/diff/10001/src/mark-compact.cc#newcode1081
src/mark-compact.cc:1081: code_map->set(new_length++, code_map->get(i));
kContextOffset = 0
https://codereview.chromium.org/14794007/diff/10001/src/mark-compact.cc#newcode1090
src/mark-compact.cc:1090: code_map->set(new_length++, code_map->get(i +
1));
kCodeOffset = 1
https://codereview.chromium.org/14794007/diff/10001/src/mark-compact.cc#newcode1099
src/mark-compact.cc:1099: code_map->set(new_length++, code_map->get(i +
2));
kLiteralsOffset = 2
https://codereview.chromium.org/14794007/diff/10001/src/mark-compact.cc#newcode1202
src/mark-compact.cc:1202: }
A follow-up CL could refactor the list handling code.
https://codereview.chromium.org/14794007/diff/10001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/14794007/diff/10001/src/objects.cc#newcode8998
src/objects.cc:8998: MaybeObject* maybe =
heap->AllocateFixedArray(kEntriesStart + kEntryLength);
can we have another constant for that kEntriesStart + kEntryLength, like
kFixedArraySize (kSecondEntryIndex)
https://codereview.chromium.org/14794007/diff/10001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/14794007/diff/10001/src/x64/code-stubs-x64.cc#newcode303
src/x64/code-stubs-x64.cc:303: __ subq(rdx,
Immediate(SharedFunctionInfo::kEntryLength)); // Skip an entry.
Do you want to delete the comment, for consistency reasons.
https://codereview.chromium.org/14794007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
