https://codereview.chromium.org/14978007/diff/3001/src/array.js
File src/array.js (right):
https://codereview.chromium.org/14978007/diff/3001/src/array.js#newcode432
src/array.js:432:
On 2013/05/16 00:45:30, adamk wrote:
Nit: no need for this blank line
Done.
https://codereview.chromium.org/14978007/diff/3001/src/object-observe.js
File src/object-observe.js (right):
https://codereview.chromium.org/14978007/diff/3001/src/object-observe.js#newcode306
src/object-observe.js:306: removed: removed,
I think the answer is probably yes. Arv?
The freezing isn't for security, it's for observers not messing with
each other, (and so we don't need to create one for each observer).
I've added a todo (all freezing is disabled right now). The bummer is
that even with Adamk's work on freezing, frozen array's are likely to be
slow, but I think Adam & Toon have some ideas about this for the future,
so maybe there's hope.
On 2013/05/16 00:45:30, adamk wrote:
Spec question: are we OK with the 'removed' array being mutable? It
seems a bit
off to freeze the changeRecord but not the array. Of course, even
after I speed
up freeze, frozen arrays will still be slow, so...
https://codereview.chromium.org/14978007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
