https://codereview.chromium.org/15085026/diff/1/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):
https://codereview.chromium.org/15085026/diff/1/src/arm/macro-assembler-arm.h#newcode1196
src/arm/macro-assembler-arm.h:1196: void TrySmiTag(Register reg,
Register src, Label* not_a_smi) {
If these macro are used in crankshaft then you may have to ask the
register allocator for an extra temp register and I was worried it could
impact performance.
In modern cores with register renaming, which register you use is
irrelevant and ip should only be used by the macro assembler (though I
believe this is not true in practice so maybe I should push another
clean up patch)
If you prefer the flexibility of controlling the scratch register let me
know and I'll upload a new patch.
https://codereview.chromium.org/15085026/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
