Revision: 14726
Author: [email protected]
Date: Tue May 21 02:25:57 2013
Log: Make Runtime_Abort print to stderr instead of stdout.
[email protected]
Review URL: https://codereview.chromium.org/15298005
http://code.google.com/p/v8/source/detail?r=14726
Modified:
/branches/bleeding_edge/src/checks.cc
/branches/bleeding_edge/src/heap.cc
/branches/bleeding_edge/src/isolate.cc
/branches/bleeding_edge/src/isolate.h
/branches/bleeding_edge/src/runtime.cc
=======================================
--- /branches/bleeding_edge/src/checks.cc Fri Dec 14 06:27:06 2012
+++ /branches/bleeding_edge/src/checks.cc Tue May 21 02:25:57 2013
@@ -53,7 +53,7 @@
if (fatal_error_handler_nesting_depth < 3) {
if (i::FLAG_stack_trace_on_abort) {
// Call this one twice on double fault
- i::Isolate::Current()->PrintStack();
+ i::Isolate::Current()->PrintStack(stderr);
}
}
i::OS::Abort();
=======================================
--- /branches/bleeding_edge/src/heap.cc Fri May 17 06:54:12 2013
+++ /branches/bleeding_edge/src/heap.cc Tue May 21 02:25:57 2013
@@ -5933,7 +5933,7 @@
void Heap::Print() {
if (!HasBeenSetUp()) return;
- isolate()->PrintStack();
+ isolate()->PrintStack(stdout);
AllSpaces spaces(this);
for (Space* space = spaces.next(); space != NULL; space = spaces.next())
{
space->Print();
=======================================
--- /branches/bleeding_edge/src/isolate.cc Mon May 20 23:36:24 2013
+++ /branches/bleeding_edge/src/isolate.cc Tue May 21 02:25:57 2013
@@ -835,7 +835,7 @@
}
-void Isolate::PrintStack() {
+void Isolate::PrintStack(FILE* out) {
if (stack_trace_nesting_level_ == 0) {
stack_trace_nesting_level_++;
@@ -850,7 +850,7 @@
StringStream accumulator(allocator);
incomplete_message_ = &accumulator;
PrintStack(&accumulator);
- accumulator.OutputToStdOut();
+ accumulator.OutputToFile(out);
InitializeLoggingAndCounters();
accumulator.Log();
incomplete_message_ = NULL;
@@ -865,7 +865,7 @@
"\n\nAttempt to print stack while printing stack (double fault)\n");
OS::PrintError(
"If you are lucky you may find a partial stack dump on stdout.\n\n");
- incomplete_message_->OutputToStdOut();
+ incomplete_message_->OutputToFile(out);
}
}
=======================================
--- /branches/bleeding_edge/src/isolate.h Mon May 20 23:36:24 2013
+++ /branches/bleeding_edge/src/isolate.h Tue May 21 02:25:57 2013
@@ -725,7 +725,7 @@
void PrintCurrentStackTrace(FILE* out);
void PrintStackTrace(FILE* out, char* thread_data);
void PrintStack(StringStream* accumulator);
- void PrintStack();
+ void PrintStack(FILE* out);
Handle<String> StackTraceString();
NO_INLINE(void PushStackTraceAndDie(unsigned int magic,
Object* object,
=======================================
--- /branches/bleeding_edge/src/runtime.cc Thu May 16 04:57:23 2013
+++ /branches/bleeding_edge/src/runtime.cc Tue May 21 02:25:57 2013
@@ -8991,7 +8991,7 @@
RUNTIME_FUNCTION(MaybeObject*, Runtime_DebugTrace) {
NoHandleAllocation ha(isolate);
ASSERT(args.length() == 0);
- isolate->PrintStack();
+ isolate->PrintStack(stdout);
return isolate->heap()->undefined_value();
}
@@ -13099,7 +13099,7 @@
ASSERT(args.length() == 2);
OS::PrintError("abort: %s\n",
reinterpret_cast<char*>(args[0]) + args.smi_at(1));
- isolate->PrintStack();
+ isolate->PrintStack(stderr);
OS::Abort();
UNREACHABLE();
return NULL;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
