Reviewers: Sven Panne,
https://chromiumcodereview.appspot.com/15398008/diff/1/include/v8.h
File include/v8.h (right):
https://chromiumcodereview.appspot.com/15398008/diff/1/include/v8.h#newcode5145
include/v8.h:5145: V8_INLINE(internal::Object* IntToSmi(int value)) {
On 2013/05/21 14:14:56, Sven Panne wrote:
I think returning internal::Smi* (here and below) might be more handy
and would
avoid some casts later. Or is there a reason why we can't do this?
it makes casting in v8.h much worse, since we can't know that Smi
inherits from Object here
https://chromiumcodereview.appspot.com/15398008/diff/1/include/v8.h#newcode5658
include/v8.h:5658: void ReturnValue<T>::Set(Isolate* isolate, float i) {
On 2013/05/21 14:14:56, Sven Panne wrote:
Why do we need this function if we convert to double, anyway?
removed
https://chromiumcodereview.appspot.com/15398008/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://chromiumcodereview.appspot.com/15398008/diff/1/src/objects-inl.h#newcode1112
src/objects-inl.h:1112: bool in_range = (value >= kMinValue) && (value
<= kMaxValue);
On 2013/05/21 14:14:56, Sven Panne wrote:
Not from your CL, but anyway: Can we inline this and use an ASSERT_EQ?
okay
Description:
implement fast ReturnValue setters
[email protected]
BUG=
Please review this at https://chromiumcodereview.appspot.com/15398008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M include/v8.h
M src/api.cc
M src/objects-inl.h
M test/cctest/test-api.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
