Reviewers: Jakob,
Description:
Use explicit type feedback clearing in some tests.
[email protected]
BUG=mjsunit
Please review this at https://codereview.chromium.org/15711004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/mjsunit/compiler/alloc-object.js
M test/mjsunit/external-array-no-sse2.js
M test/mjsunit/external-array.js
M test/mjsunit/fast-element-smi-check.js
Index: test/mjsunit/compiler/alloc-object.js
diff --git a/test/mjsunit/compiler/alloc-object.js
b/test/mjsunit/compiler/alloc-object.js
index
1d44efb549e95c22f6e791528ec6a9d8c8930ef1..0e593a49b3a5a4ee67395ba96a7456e10cb08faf
100644
--- a/test/mjsunit/compiler/alloc-object.js
+++ b/test/mjsunit/compiler/alloc-object.js
@@ -25,7 +25,7 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// Flags: --allow-natives-syntax --expose-gc --inline-construct
+// Flags: --allow-natives-syntax --inline-construct
// Test that inlined object allocation works for different layouts of
// objects (e.g. in object properties, slack tracking in progress or
@@ -53,7 +53,7 @@ function test(construct) {
assertEquals(5, o.y);
assertEquals(6, o.z);
%DeoptimizeFunction(test_helper);
- gc(); // Makes V8 forget about type information for test_helper.
+ %ClearFunctionTypeFeedback(test_helper);
}
function finalize_slack_tracking(construct) {
Index: test/mjsunit/external-array-no-sse2.js
diff --git a/test/mjsunit/external-array-no-sse2.js
b/test/mjsunit/external-array-no-sse2.js
index
b3d91a534c0ef450fa5b090dce6370cab1c4f6a9..c9d56217c80ad4726717bf18fd79896983021e72
100644
--- a/test/mjsunit/external-array-no-sse2.js
+++ b/test/mjsunit/external-array-no-sse2.js
@@ -25,7 +25,7 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// Flags: --allow-natives-syntax --expose-gc --noenable-sse2
+// Flags: --allow-natives-syntax --noenable-sse2
// Helper
function assertInstance(o, f) {
@@ -301,7 +301,7 @@ function run_test(test_func, array, expected_result) {
}
assertEquals(expected_result, sum);
%DeoptimizeFunction(test_func);
- gc(); // Makes V8 forget about type information for test_func.
+ %ClearFunctionTypeFeedback(test_func);
}
function run_bounds_test(test_func, array, expected_result) {
@@ -350,8 +350,7 @@ for (var t = 0; t < types.length; t++) {
%OptimizeFunctionOnNextCall(run_bounds_test);
run_bounds_test(a);
%DeoptimizeFunction(run_bounds_test);
- gc(); // Makes V8 forget about type information for test_func.
-
+ %ClearFunctionTypeFeedback(run_bounds_test);
}
function array_load_set_smi_check(a) {
@@ -370,7 +369,7 @@ for (var t = 0; t < types.length; t++) {
array_load_set_smi_check2(a);
array_load_set_smi_check2(0);
%DeoptimizeFunction(array_load_set_smi_check2);
- gc(); // Makes V8 forget about type information for
array_load_set_smi_check.
+ %ClearFunctionTypeFeedback(array_load_set_smi_check2);
}
// Check handling of undefined in 32- and 64-bit external float arrays.
Index: test/mjsunit/external-array.js
diff --git a/test/mjsunit/external-array.js b/test/mjsunit/external-array.js
index
e61ff453acbb1f2269f916879371dc55dcbe36e1..bfdab8abff9430db4b88e2254ba9b76369dce176
100644
--- a/test/mjsunit/external-array.js
+++ b/test/mjsunit/external-array.js
@@ -25,7 +25,7 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// Flags: --allow-natives-syntax --expose-gc
+// Flags: --allow-natives-syntax
// Helper
function assertInstance(o, f) {
@@ -301,7 +301,7 @@ function run_test(test_func, array, expected_result) {
}
assertEquals(expected_result, sum);
%DeoptimizeFunction(test_func);
- gc(); // Makes V8 forget about type information for test_func.
+ %ClearFunctionTypeFeedback(test_func);
}
function run_bounds_test(test_func, array, expected_result) {
@@ -350,8 +350,7 @@ for (var t = 0; t < types.length; t++) {
%OptimizeFunctionOnNextCall(run_bounds_test);
run_bounds_test(a);
%DeoptimizeFunction(run_bounds_test);
- gc(); // Makes V8 forget about type information for test_func.
-
+ %ClearFunctionTypeFeedback(run_bounds_test);
}
function array_load_set_smi_check(a) {
@@ -370,7 +369,7 @@ for (var t = 0; t < types.length; t++) {
array_load_set_smi_check2(a);
array_load_set_smi_check2(0);
%DeoptimizeFunction(array_load_set_smi_check2);
- gc(); // Makes V8 forget about type information for
array_load_set_smi_check.
+ %ClearFunctionTypeFeedback(array_load_set_smi_check2);
}
// Check handling of undefined in 32- and 64-bit external float arrays.
Index: test/mjsunit/fast-element-smi-check.js
diff --git a/test/mjsunit/fast-element-smi-check.js
b/test/mjsunit/fast-element-smi-check.js
index
d0c45fe629118607e6495436ca26b1cf39347db1..3083d5fe74b4608290cec3ceed31c6a3b2499c7a
100644
--- a/test/mjsunit/fast-element-smi-check.js
+++ b/test/mjsunit/fast-element-smi-check.js
@@ -25,7 +25,7 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// Flags: --allow-natives-syntax --expose-gc
+// Flags: --allow-natives-syntax
var a = new Array(10);
@@ -46,7 +46,7 @@ test_load_set_smi_2(a);
test_load_set_smi_2(a);
test_load_set_smi_2(0);
%DeoptimizeFunction(test_load_set_smi_2);
-gc(); // Makes V8 forget about type information for test_load_set_smi.
+%ClearFunctionTypeFeedback(test_load_set_smi_2);
var b = new Object();
@@ -67,4 +67,4 @@ test_load_set_smi_4(b);
test_load_set_smi_4(b);
test_load_set_smi_4(0);
%DeoptimizeFunction(test_load_set_smi_4);
-gc(); // Makes V8 forget about type information for test_load_set_smi.
+%ClearFunctionTypeFeedback(test_load_set_smi_4);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
