Revision: 14744
Author:   [email protected]
Date:     Wed May 22 02:17:27 2013
Log:      Use explicit type feedback clearing in some tests.

[email protected]

Review URL: https://codereview.chromium.org/15711004
http://code.google.com/p/v8/source/detail?r=14744

Modified:
 /branches/bleeding_edge/test/mjsunit/compiler/alloc-object.js
 /branches/bleeding_edge/test/mjsunit/external-array-no-sse2.js
 /branches/bleeding_edge/test/mjsunit/external-array.js
 /branches/bleeding_edge/test/mjsunit/fast-element-smi-check.js

=======================================
--- /branches/bleeding_edge/test/mjsunit/compiler/alloc-object.js Thu Mar 1 03:10:28 2012 +++ /branches/bleeding_edge/test/mjsunit/compiler/alloc-object.js Wed May 22 02:17:27 2013
@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --allow-natives-syntax --expose-gc --inline-construct
+// Flags: --allow-natives-syntax --inline-construct

 // Test that inlined object allocation works for different layouts of
 // objects (e.g. in object properties, slack tracking in progress or
@@ -53,7 +53,7 @@
   assertEquals(5, o.y);
   assertEquals(6, o.z);
   %DeoptimizeFunction(test_helper);
-  gc();  // Makes V8 forget about type information for test_helper.
+  %ClearFunctionTypeFeedback(test_helper);
 }

 function finalize_slack_tracking(construct) {
=======================================
--- /branches/bleeding_edge/test/mjsunit/external-array-no-sse2.js Tue May 7 07:03:50 2013 +++ /branches/bleeding_edge/test/mjsunit/external-array-no-sse2.js Wed May 22 02:17:27 2013
@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --allow-natives-syntax --expose-gc --noenable-sse2
+// Flags: --allow-natives-syntax --noenable-sse2

 // Helper
 function assertInstance(o, f) {
@@ -301,7 +301,7 @@
   }
   assertEquals(expected_result, sum);
   %DeoptimizeFunction(test_func);
-  gc();  // Makes V8 forget about type information for test_func.
+  %ClearFunctionTypeFeedback(test_func);
 }

 function run_bounds_test(test_func, array, expected_result) {
@@ -350,8 +350,7 @@
     %OptimizeFunctionOnNextCall(run_bounds_test);
     run_bounds_test(a);
     %DeoptimizeFunction(run_bounds_test);
-    gc();  // Makes V8 forget about type information for test_func.
-
+    %ClearFunctionTypeFeedback(run_bounds_test);
   }

   function array_load_set_smi_check(a) {
@@ -370,7 +369,7 @@
   array_load_set_smi_check2(a);
   array_load_set_smi_check2(0);
   %DeoptimizeFunction(array_load_set_smi_check2);
- gc(); // Makes V8 forget about type information for array_load_set_smi_check.
+  %ClearFunctionTypeFeedback(array_load_set_smi_check2);
 }

 // Check handling of undefined in 32- and 64-bit external float arrays.
=======================================
--- /branches/bleeding_edge/test/mjsunit/external-array.js Tue May 7 07:03:50 2013 +++ /branches/bleeding_edge/test/mjsunit/external-array.js Wed May 22 02:17:27 2013
@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --allow-natives-syntax --expose-gc
+// Flags: --allow-natives-syntax

 // Helper
 function assertInstance(o, f) {
@@ -301,7 +301,7 @@
   }
   assertEquals(expected_result, sum);
   %DeoptimizeFunction(test_func);
-  gc();  // Makes V8 forget about type information for test_func.
+  %ClearFunctionTypeFeedback(test_func);
 }

 function run_bounds_test(test_func, array, expected_result) {
@@ -350,8 +350,7 @@
     %OptimizeFunctionOnNextCall(run_bounds_test);
     run_bounds_test(a);
     %DeoptimizeFunction(run_bounds_test);
-    gc();  // Makes V8 forget about type information for test_func.
-
+    %ClearFunctionTypeFeedback(run_bounds_test);
   }

   function array_load_set_smi_check(a) {
@@ -370,7 +369,7 @@
   array_load_set_smi_check2(a);
   array_load_set_smi_check2(0);
   %DeoptimizeFunction(array_load_set_smi_check2);
- gc(); // Makes V8 forget about type information for array_load_set_smi_check.
+  %ClearFunctionTypeFeedback(array_load_set_smi_check2);
 }

 // Check handling of undefined in 32- and 64-bit external float arrays.
=======================================
--- /branches/bleeding_edge/test/mjsunit/fast-element-smi-check.js Mon May 23 06:42:33 2011 +++ /branches/bleeding_edge/test/mjsunit/fast-element-smi-check.js Wed May 22 02:17:27 2013
@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-// Flags: --allow-natives-syntax --expose-gc
+// Flags: --allow-natives-syntax

 var a = new Array(10);

@@ -46,7 +46,7 @@
 test_load_set_smi_2(a);
 test_load_set_smi_2(0);
 %DeoptimizeFunction(test_load_set_smi_2);
-gc();  // Makes V8 forget about type information for test_load_set_smi.
+%ClearFunctionTypeFeedback(test_load_set_smi_2);

 var b = new Object();

@@ -67,4 +67,4 @@
 test_load_set_smi_4(b);
 test_load_set_smi_4(0);
 %DeoptimizeFunction(test_load_set_smi_4);
-gc();  // Makes V8 forget about type information for test_load_set_smi.
+%ClearFunctionTypeFeedback(test_load_set_smi_4);

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to