Reviewers: Jakob,

Message:
PTAL

Description:
Fix Windows shared library build.

We cannot dll-export templates.

[email protected]

Please review this at https://chromiumcodereview.appspot.com/15697006/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M include/v8.h


Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index b3dff3fee107a6e3992e925b488d8ba760723e50..37bd427df205ee77771445f5448c85612b8692f5 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -2735,7 +2735,7 @@ class V8EXPORT Template : public Data {


 template<typename T>
-class V8EXPORT ReturnValue {
+class ReturnValue {
  public:
   V8_INLINE(explicit ReturnValue(internal::Object** slot));
   // Handle setters
@@ -2763,7 +2763,7 @@ class V8EXPORT ReturnValue {
  * the holder of the function.
  */
 template<typename T>
-class V8EXPORT FunctionCallbackInfo {
+class FunctionCallbackInfo {
  public:
   V8_INLINE(int Length() const);
   V8_INLINE(Local<Value> operator[](int i) const);
@@ -2811,7 +2811,7 @@ class V8EXPORT Arguments : public FunctionCallbackInfo<Value> {
  * of the property access.
  */
 template<typename T>
-class V8EXPORT PropertyCallbackInfo {
+class PropertyCallbackInfo {
  public:
   V8_INLINE(Isolate* GetIsolate() const);
   V8_INLINE(Local<Value> Data() const);


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to