LGTM with comments, and if it doesn't cause unexpected deopts/regressions.
https://chromiumcodereview.appspot.com/15745006/diff/1/test/mjsunit/regress/regress-copy-hole-to-field.js
File test/mjsunit/regress/regress-copy-hole-to-field.js (right):
https://chromiumcodereview.appspot.com/15745006/diff/1/test/mjsunit/regress/regress-copy-hole-to-field.js#newcode42
test/mjsunit/regress/regress-copy-hole-to-field.js:42: print(o.a);
I think you want to assertEquals(undefined, o.a) here, not just print
the value.
https://chromiumcodereview.appspot.com/15745006/diff/1/test/mjsunit/regress/regress-copy-hole-to-field.js#newcode56
test/mjsunit/regress/regress-copy-hole-to-field.js:56: print(o.ab);
again
https://chromiumcodereview.appspot.com/15745006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
