On 2013/05/23 05:08:47, Yury Semikhatsky wrote:
On 2013/05/21 10:38:29, Sven Panne wrote:
> Hmmm, somehow SampleWhenFrameIsNotSetup is still flaky,
CheckChildrenNames
is
> unconditionally called and sometimes has a failing CHECK. A new fix
would be
> highly appreciated, otherwise we'll have to disable the test again.
This is weird. Do you remember what was the unexpected node under root? I
didn't
see this locally.
Ok, I see it failed on windows but not sure why, the profile dumped looks
fine
and should have passed all the checks in the test, will investigate:
=== cctest/test-cpu-profiler/SampleWhenFrameIsNotSetup ===
--- stdout ---
[Top down]:
2 0 (root) [-1] #1
2 2 (program) [-1] #2
Command: E:\b\build\slave\v8-win32\build\v8\build\Release\cctest.exe
test-cpu-profiler/SampleWhenFrameIsNotSetup --nobreak-on-abort
--nodead-code-elimination --nofold-constants
--testing_serialization_file=E:\b\build\slave\v8-win32\build\v8\out\.serdes\serdes_test-cpu-profiler/SampleWhenFrameIsNotSetup
https://codereview.chromium.org/14845018/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
