Almost LGTM.
https://codereview.chromium.org/15743006/diff/3001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/15743006/diff/3001/src/x64/lithium-codegen-x64.cc#newcode1688
src/x64/lithium-codegen-x64.cc:1688: __ SmiToInteger32(value, value);
No.
https://codereview.chromium.org/15743006/diff/3001/src/x64/lithium-codegen-x64.cc#newcode1689
src/x64/lithium-codegen-x64.cc:1689: __ SmiToInteger32(index, index);
No, no, no.
https://codereview.chromium.org/15743006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
