Comments addressed. Platform ports done, one part is missing on ARM (see
TODO),
but I'll leave that to our specialists. :-)
https://chromiumcodereview.appspot.com/15735005/diff/4001/src/code-stubs.h
File src/code-stubs.h (right):
https://chromiumcodereview.appspot.com/15735005/diff/4001/src/code-stubs.h#newcode959
src/code-stubs.h:959: // Minor key encoding in 19 bits
TTTRRRLLLSOOOOOOOMM.
On 2013/05/23 12:05:43, Jakob wrote:
Please update this comment.
Done.
https://chromiumcodereview.appspot.com/15735005/diff/4001/src/ic.cc
File src/ic.cc (right):
https://chromiumcodereview.appspot.com/15735005/diff/4001/src/ic.cc#newcode2610
src/ic.cc:2610: (!previous_has_fixed_right_arg ||
Ooops, forgot that. Fixed.
https://chromiumcodereview.appspot.com/15735005/diff/4001/src/ic.cc#newcode2663
src/ic.cc:2663: PrintF(" ((%s+%s",
While debugging this, I cleaned this trace output up a bit (and the one
for unary ops) to be more uniform and giving it ML-syntax. ;-)
https://chromiumcodereview.appspot.com/15735005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
