Reviewers: Paul Lind, Toon Verwaest, danno, kisg, kilvadyb,
Description:
MIPS: Omit smi-check for write-barrier unless tagged.
Port r14767 (40dd85ec)
BUG=
Please review this at https://codereview.chromium.org/15745021/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/mips/stub-cache-mips.cc
Index: src/mips/stub-cache-mips.cc
diff --git a/src/mips/stub-cache-mips.cc b/src/mips/stub-cache-mips.cc
index
4a73be2dbe983798e99cf2dc7f6d37ccc9499411..aced0ea39df15168c1ae23618f3be94b1f7660bd
100644
--- a/src/mips/stub-cache-mips.cc
+++ b/src/mips/stub-cache-mips.cc
@@ -571,6 +571,8 @@ void
StubCompiler::GenerateStoreTransition(MacroAssembler* masm,
index -= object->map()->inobject_properties();
// TODO(verwaest): Share this code as a code stub.
+ SmiCheck smi_check = representation.IsTagged()
+ ? INLINE_SMI_CHECK : OMIT_SMI_CHECK;
if (index < 0) {
// Set the property straight into the object.
int offset = object->map()->instance_size() + (index * kPointerSize);
@@ -596,7 +598,9 @@ void
StubCompiler::GenerateStoreTransition(MacroAssembler* masm,
name_reg,
scratch1,
kRAHasNotBeenSaved,
- kDontSaveFPRegs);
+ kDontSaveFPRegs,
+ EMIT_REMEMBERED_SET,
+ smi_check);
}
} else {
// Write to the properties array.
@@ -626,7 +630,9 @@ void
StubCompiler::GenerateStoreTransition(MacroAssembler* masm,
name_reg,
receiver_reg,
kRAHasNotBeenSaved,
- kDontSaveFPRegs);
+ kDontSaveFPRegs,
+ EMIT_REMEMBERED_SET,
+ smi_check);
}
}
@@ -715,6 +721,8 @@ void StubCompiler::GenerateStoreField(MacroAssembler*
masm,
}
// TODO(verwaest): Share this code as a code stub.
+ SmiCheck smi_check = representation.IsTagged()
+ ? INLINE_SMI_CHECK : OMIT_SMI_CHECK;
if (index < 0) {
// Set the property straight into the object.
int offset = object->map()->instance_size() + (index * kPointerSize);
@@ -732,7 +740,9 @@ void StubCompiler::GenerateStoreField(MacroAssembler*
masm,
name_reg,
scratch1,
kRAHasNotBeenSaved,
- kDontSaveFPRegs);
+ kDontSaveFPRegs,
+ EMIT_REMEMBERED_SET,
+ smi_check);
}
} else {
// Write to the properties array.
@@ -754,7 +764,9 @@ void StubCompiler::GenerateStoreField(MacroAssembler*
masm,
name_reg,
receiver_reg,
kRAHasNotBeenSaved,
- kDontSaveFPRegs);
+ kDontSaveFPRegs,
+ EMIT_REMEMBERED_SET,
+ smi_check);
}
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
