https://codereview.chromium.org/16051002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/16051002/diff/1/src/objects.cc#newcode6747
src/objects.cc:6747: int mask = DONT_DELETE | DONT_ENUM;
This is very confusing to me. Don't we just want to add DONT_DELETE and
DONT_ENUM to all attributes of a frozen object (so add it to the client
of CopyUpToAddAttributes), and still mask out READ_ONLY from all
callbacks; cause it's never valid?

In this version it doesn't look like a generic CopyUpToAddAttributes at
all...

https://codereview.chromium.org/16051002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to