LGTM with a nit.
https://codereview.chromium.org/15994003/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/15994003/diff/1/include/v8.h#newcode378
include/v8.h:378: template<class F>
Similar code has been there before, but anyway: Moving the "template"
part into its own line makes thing quite hard to read IMHO. The template
part is part of the signature, anyway.
Can we consistently merge those lines? Or is some silly presubmit tool
unhappy with this?
https://codereview.chromium.org/15994003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
