LGTM
https://chromiumcodereview.appspot.com/15932011/diff/31/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (left):
https://chromiumcodereview.appspot.com/15932011/diff/31/src/hydrogen-instructions.h#oldcode3530
src/hydrogen-instructions.h:3530: enum BoundsCheckKeyMode {
Yay! Clean up ALL the messes!
https://chromiumcodereview.appspot.com/15932011/diff/31/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://chromiumcodereview.appspot.com/15932011/diff/31/src/ia32/lithium-codegen-ia32.cc#newcode1760
src/ia32/lithium-codegen-ia32.cc:1760:
ASSERT(instr->result()->IsRegister());
We don't need this ASSERT; ToRegister(foo) does an
ASSERT(foo->IsRegister()) anyway. Feel free to remove it from
DoConstantI as well.
https://chromiumcodereview.appspot.com/15932011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
