LGTM with two comments.
https://codereview.chromium.org/15952004/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/15952004/diff/1/src/hydrogen-instructions.cc#newcode1815
src/hydrogen-instructions.cc:1815: // The magnitude of the modulus is
bounded by the right operand.
A comment why we need to go through negtive-absolutes here would be
nice. After discussing it offline I assume it's because of overflow at
or near kMinInt.
https://codereview.chromium.org/15952004/diff/1/src/hydrogen-instructions.cc#newcode1816
src/hydrogen-instructions.cc:1816: int32_t positive_bound =
-Min(NegAbs(b->lower()), NegAbs(b->upper())) - 1;
Not completely sure but isn't there a parenthesis missing around the
whole expression after the "-" operator?
https://codereview.chromium.org/15952004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
