Addressed comments.
https://chromiumcodereview.appspot.com/15952007/diff/13/src/hydrogen.cc
File src/hydrogen.cc (right):
https://chromiumcodereview.appspot.com/15952007/diff/13/src/hydrogen.cc#newcode1589
src/hydrogen.cc:1589:
holey_store->SetFlag(HValue::kAllowUndefinedAsNaN);
On 2013/05/29 15:33:16, danno wrote:
Maybe a comment, e.g. "Allow NaN hole values to be converted to their
tagged
counterparts." Also, maybe add an if? e.g.
if (IsFastHoleyDoubleElementsKind(to_element_kind)) {
holey_store->SetFlag(HValue::kAllowUndefinedAsNaN);
}
Done.
https://chromiumcodereview.appspot.com/15952007/diff/13/src/hydrogen.cc#newcode10109
src/hydrogen.cc:10109: store->SetFlag(HValue::kAllowUndefinedAsNaN);
On 2013/05/29 15:33:16, danno wrote:
Are you sure you need this? Since there is no change involved, I don't
see why
this flag needs to be cleared.
Done.
https://chromiumcodereview.appspot.com/15952007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
