Just FYI to consider, benchmarks seems to be running a little bit faster
after
applying this patch.
Before:
Richards: 15995
DeltaBlue: 17270
Crypto: 17093
RayTrace: 17763
EarleyBoyer: 20444
RegExp: 2822
Splay: 5866
NavierStokes: 20310
----
Score (version 7): 12448
After:
Richards: 15992
DeltaBlue: 18354
Crypto: 17104
RayTrace: 17763
EarleyBoyer: 20204
RegExp: 2953
Splay: 5805
NavierStokes: 19846
----
Score (version 7): 12544
https://codereview.chromium.org/16128004/diff/15001/src/hydrogen-gvn.cc
File src/hydrogen-gvn.cc (right):
https://codereview.chromium.org/16128004/diff/15001/src/hydrogen-gvn.cc#newcode408
src/hydrogen-gvn.cc:408: instr->IsDeoptCounter() ||
instr->IsDeoptCounterAdd()) {
On 2013/06/03 07:30:44, Sven Panne wrote:
This is a no-go: We're doing something wrong if we have to change GVN
for a
localized performance improvement.
Well, its just DeoptCounterAdd that behaves like SoftDeoptimize in some
cases.
https://codereview.chromium.org/16128004/diff/15001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/16128004/diff/15001/src/hydrogen.cc#newcode4949
src/hydrogen.cc:4949: void
HOptimizedGraphBuilder::VisitSwitchStatement(SwitchStatement* stmt) {
On 2013/06/03 07:30:44, Sven Panne wrote:
We shouldn't grow this monster even more, making it basically
non-understandable
and unmaintainable (>200 lines).
Surely it can be split in multiple parts.
https://codereview.chromium.org/16128004/diff/15001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/16128004/diff/15001/src/objects.h#newcode4496
src/objects.h:4496: DECL_ACCESSORS(deopt_counter_cells, FixedArray)
On 2013/06/03 07:30:44, Sven Panne wrote:
Do we really have space left without going over our size threshold
here?
Well... no assertion happens for me, so it seems like yes?
https://codereview.chromium.org/16128004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
