https://codereview.chromium.org/15943002/diff/17001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/15943002/diff/17001/src/api.cc#newcode6099
src/api.cc:6099: i::Handle<i::ExternalArray> elements =
On 2013/06/03 13:09:04, Dmitry Lomov (chromium) wrote:
DataView is not a external array, so everything here is not needed.
Sorry, that's a left-over from my initial attempt. The DataView we have
in node.js is indexable for convenience reasons. I thought I'd removed
it from the V8 patch but I probably botched a rebase.
https://codereview.chromium.org/15943002/diff/17001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/15943002/diff/17001/src/objects-inl.h#newcode5335
src/objects-inl.h:5335: size_t byte_length =
static_cast<size_t>(this->byte_length()->Number());
On 2013/06/03 13:09:04, Dmitry Lomov (chromium) wrote:
Use NumberToSize
I copied that from ArrayBuffer actually, to keep friction as low as
possible. :-)
Want me to update that as well?
https://codereview.chromium.org/15943002/diff/17001/src/utils.h
File src/utils.h (right):
https://codereview.chromium.org/15943002/diff/17001/src/utils.h#newcode267
src/utils.h:267: inline enum Endianness GetEndianness() {
On 2013/06/03 13:09:04, Dmitry Lomov (chromium) wrote:
This belongs to cpu.h. Should be a #define with possibly
STATIC_ASSERT, not a
runtime function
I'll move it but is turning it into a macro necessary? It's effectively
a compile-time constant and it avoids a lot of compiler-specific
#ifdefs.
https://codereview.chromium.org/15943002/diff/17001/test/mjsunit/harmony/dataview.js
File test/mjsunit/harmony/dataview.js (right):
https://codereview.chromium.org/15943002/diff/17001/test/mjsunit/harmony/dataview.js#newcode30
test/mjsunit/harmony/dataview.js:30: assertThrows("DataView()",
TypeError);
On 2013/06/03 13:09:04, Dmitry Lomov (chromium) wrote:
Please do not use string version of assertThrows, use the version that
takes a a
function:
assertThrows(function() { DataView(); }, TypeError);
Will do. Out of curiosity, is it a style thing or are there tangible
benefits?
https://codereview.chromium.org/15943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
