LGTM with a suggestion.
https://codereview.chromium.org/15735005/diff/35001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/15735005/diff/35001/src/code-stubs.h#newcode942
src/code-stubs.h:942:
FixedRightArgValueBits::is_valid(WhichPowerOf2(value));
nit: It would be nice to s/WhichPowerOf2/encode_arg_value/ here, however
that would create an infinite recursion with the ASSERT in
encode_arg_value(). You'd have to move the ASSERT to the call sites,
i.e. into the two ctors. Your call. (Yet another alternative would be to
split encode_arg_value into an entry point and and ..._internal
function, but that seems overkill.)
https://codereview.chromium.org/15735005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
