Reviewers: Jakob, alph, loislo, danno,
Description:
CPU profiler should support names of accessors set via
v8::Object::SetAccessor
This change fixes the case when the accessors are invoked from
JSObject::{Get,Set}PropertyWithCallback.
It already works for inlined calls generated by
StoreStubCompiler::CompileStoreCallback. The same still needs to be fixed
for
getter invocations generated by BaseLoadStubCompiler::CompileLoadCallback,
corresponding case is commented out in the new test.
This is a slightly modified version of r14915 which was rolled back due to
test
timeout on Windows. Compared to r14915 the new tests use
OS::TimeCurrentMillis
instead of OS::Ticks as OS::Ticks has ms precision on Windows and trying to
wait
10 ticks (us) will result in at least 1 ms pause.
BUG=244580
Please review this at https://codereview.chromium.org/15995017/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/objects.cc
M test/cctest/test-cpu-profiler.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
