Addressed comments. Landing.
https://codereview.chromium.org/15714005/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/15714005/diff/1/src/hydrogen-instructions.h#newcode4848
src/hydrogen-instructions.h:4848: }
On 2013/06/04 07:44:19, Hannes Payer wrote:
add newline
Done.
https://codereview.chromium.org/15714005/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/15714005/diff/1/src/hydrogen.cc#newcode8861
src/hydrogen.cc:8861: initial_map_value->DeleteAndReplaceWith(NULL);
On 2013/06/04 07:44:19, Hannes Payer wrote:
Should we create a separate function for that piece of code?
RemoveInstructions(HInstruction* instruction, Handle<Map>map);
As discussed offline: We decided not to provide a supporting function
for this removal of instruction because we consider it a hack and don't
want to promote hacks with supporting code. The correct way to solve
this is with non-destructive inlining that first tries to build a
sub-graph before mutating the parent graph. The TODO comment was adapted
to reflect that.
https://codereview.chromium.org/15714005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
