LGTM! Renaming nits.
https://codereview.chromium.org/16206007/diff/1/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/16206007/diff/1/src/code-stubs.h#newcode1701
src/code-stubs.h:1701: bool disable_allocation_sites() const {
This is not a real getter. The function name should be CamelCase.
Moreover it should start with Is*.
https://codereview.chromium.org/16206007/diff/1/src/code-stubs.h#newcode1717
src/code-stubs.h:1717: class DisableAllocationSitesBits: public
BitField<bool, 8, 1> {};
Do you want to rename it to DisableAllocationSitesBit, since it is just
one bit referring to an allocation site?
https://codereview.chromium.org/16206007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
