Revision: 14936
Author: [email protected]
Date: Tue Jun 4 06:36:18 2013
Log: Remove V8_USE_OLD_STYLE_PERSISTENT_HANDLE_VISITORS.
Blink has migrated to use the new style visitors.
BUG=
[email protected], [email protected]
Review URL: https://codereview.chromium.org/16360005
Patch from Marja Hölttä <[email protected]>.
http://code.google.com/p/v8/source/detail?r=14936
Modified:
/branches/bleeding_edge/include/v8.h
/branches/bleeding_edge/src/api.cc
/branches/bleeding_edge/test/cctest/test-api.cc
=======================================
--- /branches/bleeding_edge/include/v8.h Mon Jun 3 08:32:22 2013
+++ /branches/bleeding_edge/include/v8.h Tue Jun 4 06:36:18 2013
@@ -223,7 +223,6 @@
#define V8_USE_UNSAFE_HANDLES
-#define V8_USE_OLD_STYLE_PERSISTENT_HANDLE_VISITORS
/**
* An object reference managed by the v8 garbage collector.
@@ -4125,13 +4124,8 @@
class V8EXPORT PersistentHandleVisitor { // NOLINT
public:
virtual ~PersistentHandleVisitor() {}
-#ifdef V8_USE_OLD_STYLE_PERSISTENT_HANDLE_VISITORS
- virtual void VisitPersistentHandle(Persistent<Value> value,
- uint16_t class_id) {}
-#else
virtual void VisitPersistentHandle(Persistent<Value>* value,
uint16_t class_id) {}
-#endif
};
=======================================
--- /branches/bleeding_edge/src/api.cc Tue Jun 4 03:30:05 2013
+++ /branches/bleeding_edge/src/api.cc Tue Jun 4 06:36:18 2013
@@ -5087,14 +5087,9 @@
UNREACHABLE();
}
virtual void VisitEmbedderReference(i::Object** p, uint16_t class_id) {
-#ifdef V8_USE_OLD_STYLE_PERSISTENT_HANDLE_VISITORS
- visitor_->VisitPersistentHandle(ToApi<Value>(i::Handle<i::Object>(p)),
- class_id);
-#else
Value* value = ToApi<Value>(i::Handle<i::Object>(p));
visitor_->VisitPersistentHandle(
reinterpret_cast<Persistent<Value>*>(&value), class_id);
-#endif
}
private:
PersistentHandleVisitor* visitor_;
=======================================
--- /branches/bleeding_edge/test/cctest/test-api.cc Tue Jun 4 03:30:05 2013
+++ /branches/bleeding_edge/test/cctest/test-api.cc Tue Jun 4 06:36:18 2013
@@ -17536,13 +17536,6 @@
public:
explicit Visitor42(v8::Persistent<v8::Object>* object)
: counter_(0), object_(object) { }
-
-#ifdef V8_USE_OLD_STYLE_PERSISTENT_HANDLE_VISITORS
- virtual void VisitPersistentHandle(Persistent<Value> value,
- uint16_t class_id) {
- VisitPersistentHandle(&value, class_id);
- }
-#endif
virtual void VisitPersistentHandle(Persistent<Value>* value,
uint16_t class_id) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
