Revision: 14942
Author: [email protected]
Date: Tue Jun 4 13:14:37 2013
Log: MIPS: Deprecate FACTORY helper macro.
Port r14931 (a914442)
Original commit message:
This removes the FACTORY helper macro to avoid accidental TLS access
when using the factory. Most internal code has access to the Isolate by
now whereas tests which are not performance critical still heavily use
TLS access through explicit Isolate::Current() calls.
BUG=
Review URL: https://codereview.chromium.org/15994011
Patch from Balazs Kilvady <[email protected]>.
http://code.google.com/p/v8/source/detail?r=14942
Modified:
/branches/bleeding_edge/src/mips/code-stubs-mips.cc
/branches/bleeding_edge/src/mips/full-codegen-mips.cc
/branches/bleeding_edge/src/mips/regexp-macro-assembler-mips.cc
=======================================
--- /branches/bleeding_edge/src/mips/code-stubs-mips.cc Tue Jun 4 13:11:16
2013
+++ /branches/bleeding_edge/src/mips/code-stubs-mips.cc Tue Jun 4 13:14:37
2013
@@ -961,7 +961,7 @@
__ li(exp_mask_reg, Operand(HeapNumber::kExponentMask));
- // Test for NaN. Sadly, we can't just compare to factory->nan_value(),
+ // Test for NaN. Sadly, we can't just compare to Factory::nan_value(),
// so we do the second best thing - test it ourselves.
// They are both equal and they are not both Smis so both of them are not
// Smis. If it's not a heap number, then return equal.
=======================================
--- /branches/bleeding_edge/src/mips/full-codegen-mips.cc Wed May 29
18:24:45 2013
+++ /branches/bleeding_edge/src/mips/full-codegen-mips.cc Tue Jun 4
13:14:37 2013
@@ -3039,7 +3039,7 @@
// string "valueOf" the result is false.
// The use of t2 to store the valueOf string assumes that it is not
otherwise
// used in the loop below.
- __ li(t2, Operand(FACTORY->value_of_string()));
+ __ li(t2, Operand(isolate()->factory()->value_of_string()));
__ jmp(&entry);
__ bind(&loop);
__ lw(a3, MemOperand(t0, 0));
=======================================
--- /branches/bleeding_edge/src/mips/regexp-macro-assembler-mips.cc Wed Apr
24 00:39:35 2013
+++ /branches/bleeding_edge/src/mips/regexp-macro-assembler-mips.cc Tue
Jun 4 13:14:37 2013
@@ -929,9 +929,8 @@
CodeDesc code_desc;
masm_->GetCode(&code_desc);
- Handle<Code> code = FACTORY->NewCode(code_desc,
- Code::ComputeFlags(Code::REGEXP),
- masm_->CodeObject());
+ Handle<Code> code = isolate()->factory()->NewCode(
+ code_desc, Code::ComputeFlags(Code::REGEXP), masm_->CodeObject());
LOG(Isolate::Current(), RegExpCodeCreateEvent(*code, *source));
return Handle<HeapObject>::cast(code);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
