LGTM with two nits and one real comments in the objects.h file. Code-b-gone!
https://codereview.chromium.org/15993016/diff/3001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/15993016/diff/3001/src/heap.cc#newcode4201
src/heap.cc:4201: ASSERT(in_object_properties <=
Map::kMaxPreAllocatedPropertyFields);
Both the assert and the five lines of comments above have become
obsolete, let's drop that as well.
https://codereview.chromium.org/15993016/diff/3001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/15993016/diff/3001/src/objects.h#newcode6330
src/objects.h:6330: kCompilerHintsOffset + kPointerSize,
This should be "kInitialMapOffset + kPointerSize" as it should only
include the pointer fields, not the SMI fields.
https://codereview.chromium.org/15993016/diff/3001/test/mjsunit/bugs/618.js
File test/mjsunit/bugs/618.js (left):
https://codereview.chromium.org/15993016/diff/3001/test/mjsunit/bugs/618.js#oldcode1
test/mjsunit/bugs/618.js:1: // Copyright 2010 the V8 project authors.
All rights reserved.
Instead of deleting this file, let's move it to
mjsunit/regress/regress-618.js instead.
https://codereview.chromium.org/15993016/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
