Revision: 14951
Author: [email protected]
Date: Wed Jun 5 05:09:02 2013
Log: Fix LStoreKeyed error when tracing instruction.
LStoreKeyed can have a NULL value(), when we recognize we are storing a
constant
hole value.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/15793006
http://code.google.com/p/v8/source/detail?r=14951
Modified:
/branches/bleeding_edge/src/arm/lithium-arm.cc
/branches/bleeding_edge/src/ia32/lithium-ia32.cc
/branches/bleeding_edge/src/x64/lithium-x64.cc
=======================================
--- /branches/bleeding_edge/src/arm/lithium-arm.cc Tue Jun 4 09:41:24 2013
+++ /branches/bleeding_edge/src/arm/lithium-arm.cc Wed Jun 5 05:09:02 2013
@@ -405,7 +405,14 @@
} else {
stream->Add("] <- ");
}
- value()->PrintTo(stream);
+
+ if (value() == NULL) {
+ ASSERT(hydrogen()->IsConstantHoleStore() &&
+ hydrogen()->value()->representation().IsDouble());
+ stream->Add("<the hole(nan)>");
+ } else {
+ value()->PrintTo(stream);
+ }
}
=======================================
--- /branches/bleeding_edge/src/ia32/lithium-ia32.cc Tue Jun 4 09:41:24
2013
+++ /branches/bleeding_edge/src/ia32/lithium-ia32.cc Wed Jun 5 05:09:02
2013
@@ -452,7 +452,14 @@
} else {
stream->Add("] <- ");
}
- value()->PrintTo(stream);
+
+ if (value() == NULL) {
+ ASSERT(hydrogen()->IsConstantHoleStore() &&
+ hydrogen()->value()->representation().IsDouble());
+ stream->Add("<the hole(nan)>");
+ } else {
+ value()->PrintTo(stream);
+ }
}
=======================================
--- /branches/bleeding_edge/src/x64/lithium-x64.cc Tue Jun 4 09:41:24 2013
+++ /branches/bleeding_edge/src/x64/lithium-x64.cc Wed Jun 5 05:09:02 2013
@@ -427,7 +427,14 @@
} else {
stream->Add("] <- ");
}
- value()->PrintTo(stream);
+
+ if (value() == NULL) {
+ ASSERT(hydrogen()->IsConstantHoleStore() &&
+ hydrogen()->value()->representation().IsDouble());
+ stream->Add("<the hole(nan)>");
+ } else {
+ value()->PrintTo(stream);
+ }
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
