Reviewers: Yury Semikhatsky, loislo, ulan,
Message:
Folks, could you please take a look.
Description:
Do not force GC on each objects tracking sample.
GC takes significant part of a sample timeframe. There's no real need
to make it on every sample.
Default GC invocations made by v8 should be enough for objects tracking
purposes.
Please review this at https://codereview.chromium.org/15825019/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/heap-snapshot-generator.cc
Index: src/heap-snapshot-generator.cc
diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc
index
c4da47cb48ea674d063eb7d71f23eee6614a6c2f..9d7b1226319670c5186578cb8856e31ca9da7b3b
100644
--- a/src/heap-snapshot-generator.cc
+++ b/src/heap-snapshot-generator.cc
@@ -465,8 +465,7 @@ void HeapObjectsMap::StopHeapObjectsTracking() {
}
void HeapObjectsMap::UpdateHeapObjectsMap() {
- HEAP->CollectAllGarbage(Heap::kMakeHeapIterableMask,
- "HeapSnapshotsCollection::UpdateHeapObjectsMap");
+ HEAP->EnsureHeapIsIterable();
HeapIterator iterator(heap_);
for (HeapObject* obj = iterator.next();
obj != NULL;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
