Just a few nits for the runtime.cc file.
https://codereview.chromium.org/16399007/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/16399007/diff/1/src/runtime.cc#newcode13505
src/runtime.cc:13505: RUNTIME_FUNCTION(MaybeObject*,
Runtime_ArrayConstructor) {
Each runtime function should have it's own HandleScope (or one of the
assertion scopes).
https://codereview.chromium.org/16399007/diff/1/src/runtime.cc#newcode13516
src/runtime.cc:13516: Handle<JSFunction> constructor =
args.at<JSFunction>(parameters_start);
Use the CONVERT_ARG_HANDLE_CHECKED macro to access "args".
https://codereview.chromium.org/16399007/diff/1/src/runtime.cc#newcode13526
src/runtime.cc:13526: RUNTIME_FUNCTION(MaybeObject*,
Runtime_InternalArrayConstructor) {
Likewise.
https://codereview.chromium.org/16399007/diff/1/src/runtime.cc#newcode13534
src/runtime.cc:13534: Handle<JSFunction> constructor =
args.at<JSFunction>(parameters_start);
Use the CONVERT_ARG_HANDLE_CHECKED macro to access "args".
https://codereview.chromium.org/16399007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
