Reviewers: Michael Starzinger,
Description:
Fix bogus assertions for tracing and verify.
[email protected]
BUG=
Please review this at https://chromiumcodereview.appspot.com/15778012/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen.cc
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
d1cfb8eaf318c281bb249d03c731567f349d6ff8..f501c7c5424d73fafc59dbdc725f85c5a9f18482
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -527,7 +527,8 @@ class ReachabilityAnalyzer BASE_EMBEDDED {
void HGraph::Verify(bool do_full_verify) const {
Heap::RelocationLock(isolate()->heap());
- AllowDeferredHandleDereference allow_deferred_deref;
+ AllowHandleDereference ahd;
+ AllowDeferredHandleDereference adhd;
for (int i = 0; i < blocks_.length(); i++) {
HBasicBlock* block = blocks_.at(i);
@@ -4564,7 +4565,8 @@ void HGraph::MarkLive(HValue* ref, HValue* instr,
ZoneList<HValue*>* worklist) {
if (FLAG_trace_dead_code_elimination) {
HeapStringAllocator allocator;
StringStream stream(&allocator);
- AllowDeferredHandleDereference debug_output;
+ AllowHandleDereference ahd;
+ AllowDeferredHandleDereference adhd;
if (ref != NULL) {
ref->PrintTo(&stream);
} else {
@@ -11248,14 +11250,16 @@ void HTracer::TraceCompilation(CompilationInfo*
info) {
void HTracer::TraceLithium(const char* name, LChunk* chunk) {
ASSERT(!FLAG_parallel_recompilation);
- AllowDeferredHandleDereference debug_output;
+ AllowHandleDereference ahd;
+ AllowDeferredHandleDereference adhd;
Trace(name, chunk->graph(), chunk);
}
void HTracer::TraceHydrogen(const char* name, HGraph* graph) {
ASSERT(!FLAG_parallel_recompilation);
- AllowDeferredHandleDereference debug_output;
+ AllowHandleDereference ahd;
+ AllowDeferredHandleDereference adhd;
Trace(name, graph, NULL);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.