done
https://codereview.chromium.org/16438010/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/16438010/diff/1/src/objects.cc#newcode10963
src/objects.cc:10963: if (delete_count) {
On 2013/06/06 09:12:05, rossberg wrote:
Nit: can we make this del_cnt > 0?
Done.
https://codereview.chromium.org/16438010/diff/1/src/objects.cc#newcode10970
src/objects.cc:10970: SetProperty(deleted,
isolate->factory()->length_string(),
On 2013/06/05 17:22:03, adamk wrote:
This can go inside the if (delete_count) block.
Done.
I also wonder if the thing you actually want is a static, handlified
version of
JSArray::SetElementsLength, which will short-circuit the whole
property-setting
machinery.
Yeah. Let's wait and see if this shows up as a bottle neck.
https://codereview.chromium.org/16438010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
