Apologies for bumbling around here. I ran into this and thought I'd share here and be given advice on how to best proceed.
With the latest code grabbed from the GitHub mirror https://github.com/v8/v8 Attempts to build with: make ia32 regexp=interpreted will fail ../src/regexp-macro-assembler-irregexp.cc: In member function âvirtual v8::internal::Handle<v8::internal::HeapObject> v8::internal::RegExpMacroAssemblerIrregexp::GetCode(v8::internal::Handle<v8::internal::String>)â: ../src/regexp-macro-assembler-irregexp.cc:470: error: âFACTORYâ was not declared in this scope I'm a bit surprised by this as the commit that causes the issue was some time ago https://github.com/v8/v8/commit/1cce57726c3d422ef3ba69dd142c93523b146fd2 The following change resolves the compile problem and appears correct $ git diff diff --git a/src/regexp-macro-assembler-irregexp.cc b/src/regexp-macro-assembler index e678d60..701c12f 100644 --- a/src/regexp-macro-assembler-irregexp.cc +++ b/src/regexp-macro-assembler-irregexp.cc @@ -465,9 +465,10 @@ void RegExpMacroAssemblerIrregexp::IfRegisterEqPos(int regi Handle<HeapObject> RegExpMacroAssemblerIrregexp::GetCode( Handle<String> source) { + v8::internal::Isolate* isolate = v8::internal::Isolate::Current(); Bind(&backtrack_); Emit(BC_POP_BT, 0); - Handle<ByteArray> array = FACTORY->NewByteArray(length()); + Handle<ByteArray> array = isolate->factory()->NewByteArray(length()); Copy(array->GetDataStartAddress()); return array; } I'll happily start down the http://dev.chromium.org/developers/contributing-code path if that's the right next steps, but it seems surprising that the intepreted regexp isn't being tested regularly and thus this shouldn't have ever been a problem for this long. -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
