On 2013/06/07 11:34:01, peter.rybin wrote:

LGTM. Please add a comment on "pc - 1", something about the pc pointing to the
instruction after the break point.

Alternatively, rename FindBreakLocationFromAddress to something like
FindClosestBreakLocationBeforeAddress and leave the current implementation, but
I assume that you need it in some other places as well?


https://codereview.chromium.org/15737023/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to